Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] remove useless docstring for models #6138

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Conversation

msyyc
Copy link
Contributor

@msyyc msyyc commented Feb 25, 2025

fix #6115

in our current design, read-only are not exposed as init kwarg like it used to be (e.g. here). So we could remove the sentence Readonly variables are only populated by the server, and will be ignored when sending a request now.

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:python Issue for the Python client emitter: @typespec/http-client-python label Feb 25, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 25, 2025

All changed packages have been documented.

  • @typespec/http-client-python
Show changes

@typespec/http-client-python - fix ✏️

[python] remove useless docstring for models

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 25, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@msyyc msyyc added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 26, 2025
@msyyc msyyc added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 26, 2025
@msyyc msyyc enabled auto-merge February 26, 2025 07:54
@msyyc msyyc added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 26, 2025
@msyyc
Copy link
Contributor Author

msyyc commented Feb 27, 2025

Hi @timotheeguerin This PR is removed from merge queue at least 3 times while CI doesn't fail during the merge queue. Is there any limitation about the cost time of CI? One of Python's CI item usually takes nearly one hour: https://github.com/microsoft/typespec/runs/37827719081.

@msyyc msyyc added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 27, 2025
@msyyc msyyc added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 5749482 Feb 27, 2025
35 checks passed
@msyyc msyyc deleted the python-models-docstring branch February 27, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:python Issue for the Python client emitter: @typespec/http-client-python
Projects
None yet
3 participants